Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update video tests #431

Closed
wants to merge 6 commits into from
Closed

update video tests #431

wants to merge 6 commits into from

Conversation

JackySun9
Copy link
Contributor

No description provided.

@amauch-adobe amauch-adobe self-requested a review September 6, 2024 16:02
@Dli3 Dli3 added @video Video Block run-nala Run Nala Test Automation against PR/Branch labels Sep 6, 2024
amauch-adobe
amauch-adobe approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, based on the request from Milo Core to remove the no-longer needed checks on attributes, but instead to verify only visibility.

@JackySun9 JackySun9 closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skumar09 skumar09 skumar09 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@amauch-adobe amauch-adobe amauch-adobe approved these changes

Assignees
No one assigned
Labels
run-nala Run Nala Test Automation against PR/Branch @video Video Block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackySun9 @skumar09 @Dli3 @amauch-adobe